Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #9412: updated example of AST for TokenTypes.CTOR_CALL #10985

Merged
merged 1 commit into from Nov 27, 2021
Merged

Issue #9412: updated example of AST for TokenTypes.CTOR_CALL #10985

merged 1 commit into from Nov 27, 2021

Conversation

AbhinavRajputEXE
Copy link
Contributor

Fixes #9412 : update example of AST for TokenTypes.CTOR_CALL

@AbhinavRajputEXE
Copy link
Contributor Author

@romani , please review this PR

romani
romani requested changes Nov 27, 2021
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items:

src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java Outdated
* |--EXPR -> EXPR
* |--NUM_INT -> 1
* |--RPAREN -> )
* |--SEMI -> ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please share output of cli for such code, I think this line should have different pseudo graphic element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot (535)
Should I make it look like the AST above?
in the SUPER_CTOR_CALL example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print whole ast by cli.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romani , I changed it, this time I created a fresh AST using CLI.
Screenshot (539)

@romani
Copy link
Member

romani commented Nov 27, 2021

Squash commits merged in one

@AbhinavRajputEXE
Copy link
Contributor Author

Squash commits merged in one

did it.

@romani romani merged commit bb69e10 into checkstyle:master Nov 27, 2021
@AbhinavRajputEXE AbhinavRajputEXE deleted the my-new-check branch November 27, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update example of AST for TokenTypes.CTOR_CALL
2 participants
@AbhinavRajputEXE @romani