Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11185: Run regression testing in CI over openjdk17 #11186

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Issue #11185: Run regression testing in CI over openjdk17 #11186

merged 2 commits into from
Jan 23, 2022

Conversation

nrmancuso
Copy link
Member

@nrmancuso nrmancuso commented Jan 12, 2022 •
edited

Closes #11185.

Not much has changed, some non compilable files have been removed from the repo, as have a few compilable files. All compilable files related to new syntax are parsed with no issue.

Blocked until #11100

Reviewers, please ignore commits before Issue checkstyle#11185: Run regression testing in CI over openjdk17

@nrmancuso nrmancuso force-pushed the openjdk-17-parse branch 2 times, most recently from ee0ba11 to 3d148e4 Compare January 12, 2022 06:17
@nrmancuso nrmancuso self-assigned this Jan 12, 2022
@nrmancuso nrmancuso force-pushed the openjdk-17-parse branch 2 times, most recently from d829d5d to 988eb3d Compare January 12, 2022 13:19
@nrmancuso nrmancuso marked this pull request as draft January 12, 2022 13:20
@nrmancuso nrmancuso mentioned this pull request Jan 12, 2022
Closed
@nrmancuso nrmancuso force-pushed the openjdk-17-parse branch 3 times, most recently from bdc66f5 to 01f620c Compare January 13, 2022 13:48
@nrmancuso nrmancuso removed their assignment Jan 13, 2022
@nrmancuso nrmancuso marked this pull request as ready for review January 13, 2022 13:49
@nrmancuso nrmancuso force-pushed the openjdk-17-parse branch 4 times, most recently from 3f22155 to 918ba51 Compare January 16, 2022 16:37
rnveach
rnveach requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge once other commits are removed

@nrmancuso
Copy link
Member Author

GitHub, rebase

@nrmancuso nrmancuso force-pushed the openjdk-17-parse branch 3 times, most recently from c504a7c to 80d1dd9 Compare January 20, 2022 19:36
romani
romani approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge for last two commits.

@nrmancuso nrmancuso mentioned this pull request Jan 23, 2022
Merged
@nrmancuso nrmancuso removed the blocked label Jan 23, 2022
@rnveach rnveach merged commit d04ad60 into checkstyle:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@pbludov pbludov pbludov approved these changes

@rnveach rnveach rnveach approved these changes

Assignees

@rnveach rnveach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run regression testing in CI over openjdk17
4 participants
@nrmancuso @romani @pbludov @rnveach