Doc: improve grammar in writingchecks.xml #11379
Conversation
|
Make commit message with prefix "doc: " |
OttoKaaij
force-pushed
the
writingchecks-grammar
branch
2 times, most recently
from
4da3044
to
6edfbaf
Compare
|
Oops, sorry: 'doc' is not 'Doc' |
|
GitHub, generate web site |
|
@OttoKaaij I just want to check if there is any issues with making updates before I review the second half. I am waiting before I dive into the rest. |
|
@rnveach No problems! Intending to work through your reveiw tomorow. Thanks for your review! |
OttoKaaij
force-pushed
the
writingchecks-grammar
branch
2 times, most recently
from
7f9864a
to
0e8e434
Compare
|
@OttoKaaij, please review CI failures and fix them. |
OttoKaaij
force-pushed
the
writingchecks-grammar
branch
from
0e8e434
to
0544bf0
Compare
Should be fixed |
Please make sure you are rebasing this PR on the latest version of master. Don't create a merge commit, it has to be a rebase. |
|
I will find time today to review the second half. |
|
@OttoKaaij, please don't do more changes. Big PRs are not pleasant to review and manage. |
OttoKaaij
force-pushed
the
writingchecks-grammar
branch
from
0544bf0
to
10de957
Compare
|
Resolved all comments and rebased |
OttoKaaij
force-pushed
the
writingchecks-grammar
branch
from
10de957
to
2672e70
Compare
|
@OttoKaaij, in future PRs please do not resolve review items , just reply "done". Reviewer will resolve them as confirmation that update is done as requested. |
|
@romani that seems reasonable, thanks for letting me know :) |
|
@rnveach , please finish review |
|
@OttoKaaij There are 2 items from my first review that are still not done. Make sure you are showing any hidden conversations. |
|
@romani Please review as well. I need a moment to review it again. |
|
GitHub, generate website |
OttoKaaij
force-pushed
the
writingchecks-grammar
branch
from
2672e70
to
7eecb66
Compare
|
@rnveach I have fixed the final two comments you have up |
|
@OttoKaaij One more thing, CI is failing because this PR is so old. Please rebase on the latest master and then it can be merged safely.
|
|
GitHub, rebase |
romani
force-pushed
the
writingchecks-grammar
branch
from
7eecb66
to
7989c49
Compare
|
manually rebased |
While reading through this document to get started on more substantial contributions, I decided to attempt to fix some grammatical errors present in the document. The content of the text was very helpful, so big thanks there to the writers!