Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: remove cache from drone execution #11877

Merged
merged 2 commits into from
Jul 13, 2022
Merged

infra: remove cache from drone execution #11877

merged 2 commits into from
Jul 13, 2022

Conversation

nrmancuso
Copy link
Member

@nrmancuso nrmancuso commented Jul 10, 2022 •
edited

"Fixes" (really allows us to bypass) failure noted at: https://cloud.drone.io/checkstyle/checkstyle/11222/4/2

I am guessing that this is the same issue mentioned by @romani regarding dropbox last week in discord:

Dropbox.
Hi Roman,
This email is an automated notification from Dropbox letting you know that your Public links have been temporarily suspended for generating excessive traffic.

The file we are actually downloading now:

➜  checkstyle git:(fix-infra-2) ✗ curl -o .ci-temp/cache.tar -SsL \
    https://www.dropbox.com/s/"sh1g8o4h16p4n""x6"/cache.tar\?dl\=0

➜  checkstyle git:(fix-infra-2) cat .ci-temp/cache.tar 
<!DOCTYPE html>
<html>
<head><meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title>Dropbox - 404</title>
<link href="https://cfl.dropboxstatic.com/static/css/error.css" rel="stylesheet" type="text/css"/>
<link rel="shortcut icon" href="https://cfl.dropboxstatic.com/static/images/favicon.ico"/>
</head>
<body>
<div class="figure">
<img src="https://assets.dropbox.com/www/en-us/illustrations/spot/look-magnifying-glass.svg" alt="Error: 404"/>
</div>
<div id="errorbox">
<div class="not-found">
                <h1>Error (404)</h1>
                We can't find the page you're looking for.
                <div class="not-found--links">
                    Here are a few links that may be helpful:
                    <ul>
                        <li><a href="https://www.dropbox.com/home?_tk=fof">Home</a></li>
                        <li><a href="https://www.dropbox.com/help?_tk=fof">Help center</a></li>
                        <li><a href="https://www.dropbox.com/login?_tk=fof">Sign in</a></li>
                        <li><a href="https://www.dropbox.com/register?_tk=fof">Get a free account</a></li>
                        <li><a href="https://www.dropbox.com/plus?_tk=fof">Dropbox Plus</a></li>
                        <li><a href="https://www.dropbox.com/business?_tk=fof">Dropbox Business</a></li>
                    </ul>
                </div>
            </div>
</div>

</body>
</html>

Summary: dropbox failure preventing us from downloading maven cache helped us to realize that dealing with storing cache elsewhere wasn't really saving us any time in CI. So, we removed the cache restoration completely.

@romani
Copy link
Member

romani commented Jul 10, 2022

This is not required to merge, as side effect that we have in drone it not blocking execution.

But it shows very strange situation that I can not understand, there is no m2 cache installation but there is no download of artifacts.

If we get understanding of this paradox, I would be ok to remove restoration of cache at all.

@nrmancuso nrmancuso self-assigned this Jul 10, 2022
@nrmancuso nrmancuso force-pushed the fix-infra-2 branch 3 times, most recently from 6bbd306 to e426d54 Compare July 10, 2022 18:06
@nrmancuso
Copy link
Member Author

Link to build: https://cloud.drone.io/checkstyle/checkstyle/11289/1

@nrmancuso
Copy link
Member Author

nrmancuso commented Jul 12, 2022 •
edited

@romani see https://cloud.drone.io/checkstyle/checkstyle/11289/1/2, we do not have cache, but download of all dependencies is very fast (57 seconds).

@romani
Copy link
Member

romani commented Jul 12, 2022

lets remove caching at all.

@nrmancuso nrmancuso changed the title infra: allows for maven cache to not be restored, but continue execution infra: remove cache from drone execution Jul 13, 2022
romani
romani requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

.ci/validation.sh Show resolved Hide resolved
@nrmancuso
Copy link
Member Author

nrmancuso commented Jul 13, 2022 •
edited

Drone execution in this PR (no cache):

image

Drone execution from another PR:
image

Overall, some jobs actually completed faster, and those that didn't are very close in time. @romani I am good to remove cache, as well.

@nrmancuso nrmancuso assigned romani and unassigned nrmancuso Jul 13, 2022
@romani
Copy link
Member

romani commented Jul 13, 2022

Please put in commit reference to this PR and merge PR immediately

romani
romani approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani assigned nrmancuso and unassigned romani Jul 13, 2022
@nrmancuso nrmancuso merged commit 763773c into checkstyle:master Jul 13, 2022
@nrmancuso nrmancuso deleted the fix-infra-2 branch July 13, 2022 04:23
@nrmancuso
Copy link
Member Author

Please put in commit reference to this PR and merge PR immediately

@romani done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@nrmancuso nrmancuso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nrmancuso @romani