Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12291: fix bound condition in EmptyForInitializerPadCheck #12310

Merged
merged 1 commit into from Nov 1, 2022
Merged

Issue #12291: fix bound condition in EmptyForInitializerPadCheck #12310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheck.java
View file
Open in desktop
Expand Up @@ -152,7 +152,7 @@ public void visitToken(DetailAST ast) {
final int[] line = getLineCodePoints(lineIdx);
final int before = ast.getColumnNo() - 1;
// don't check if semi at beginning of line
if (!CodePointUtil.hasWhitespaceBefore(before, line)) {
if (ast.getColumnNo() > 0 && !CodePointUtil.hasWhitespaceBefore(before, line)) {
romani marked this conversation as resolved.
Show resolved Hide resolved
if (option == PadOption.NOSPACE
&& CommonUtil.isCodePointWhitespace(line, before)) {
log(ast, MSG_PRECEDED, SEMICOLON);
Expand Down
5 changes: 5 additions & 0 deletions ...le/checks/whitespace/emptyforinitializerpad/InputEmptyForInitializerPadDefaultConfig.java
View file
Open in desktop
Expand Up @@ -58,4 +58,9 @@ void method2()
;; ) {
}
}

void method3() {
for (
;;) {}
}
}