Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12314: Resolve Pitest suppression for misc profile #12317

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Issue #12314: Resolve Pitest suppression for misc profile #12317

merged 1 commit into from
Oct 21, 2022

Conversation

Kevin222004
Copy link
Contributor

Issue #12314: Resolve Pitest suppression for misc profile

@Kevin222004
Copy link
Contributor Author

Mutation killed at line no 211,212 https://kevin222004.github.io/solvedMISC/com.puppycrawl.tools.checkstyle.checks/NewlineAtEndOfFileCheck.java.html

romani
romani approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani
Copy link
Member

romani commented Oct 21, 2022

Please fix ci violation

[INFO] There are 2 errors reported by Checkstyle 10.0 with C:\projects\checkstyle/config/checkstyle_sevntu_checks.xml ruleset.
[ERROR] src\test\java\com\puppycrawl\tools\checkstyle\checks\NewlineAtEndOfFileCheckTest.java:[228,5] (extension) InnerClass: Fields and methods should be before inner classes.
[ERROR] src\test\java\com\puppycrawl\tools\checkstyle\checks\NewlineAtEndOfFileCheckTest.java:[228,5] (extension) CustomDeclarationOrder: Method definition in wrong order. Expected 'Method(.*)' then 'InnerClass(.*)'.

@romani romani merged commit 67a577d into checkstyle:master Oct 21, 2022
@arinmodi arinmodi mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kevin222004 @romani