Issue #12443: Fix null pointer exception on config value with trailin…

[nrmancuso]

closes #12443

[romani]

Ok to merge

[romani]

Should be merged before Sunday, to release this fix sooner

[rnveach]

#12443 (comment)
I am seeing 3 trims removed, but only 2 fixes here.

[nrmancuso]

Third trim does not need to be replaced, trim is called on argument in method.

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/AccessModifierOption.java

Lines 65 to 67 in 276263b

	public static AccessModifierOption getInstance(String modifierName) {
	return valueOf(AccessModifierOption.class, modifierName.trim().toUpperCase(Locale.ENGLISH));
	}

[rnveach]

Third trim does not need to be replaced, trim is called on argument in method.

Do we have a similar test to show it is not needed?

[nrmancuso]

This is where the other trim was located: 3080013#r90853229

Which calls

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/naming/AccessModifierOption.java

Lines 65 to 67 in 276263b

	public static AccessModifierOption getInstance(String modifierName) {
	return valueOf(AccessModifierOption.class, modifierName.trim().toUpperCase(Locale.ENGLISH));
	}

I can add another tab in config like this: public\t,\t, this will cause an unnecessary suppression since this is the test case at #12340

[nrmancuso]

@rnveach test case is added

[Vyom-Yadav]

One minor, rest LGTM :)

[rnveach]

I can add another tab in config like this: public\t,\t, this will cause an unnecessary suppression since this is the test case at #12340

There is no test case like this in the other PR.

[nrmancuso]

Linking discussion here: #12340 (comment)

Exaplanation from link above:

In other PR, we had public, \t, case taken from this PR is with tab character "on" the access modifier. The first trim in both methods took care of the single \t, the second trim takes care of the \t "on" the access modifier.