Issue #12379: Checker false violation removals on other failures #12725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnveach
requested changes
Feb 5, 2023
.ci/checker-framework.groovy
Outdated
| @@ -112,7 +112,8 @@ private static int checkCheckerFrameworkReport(final String profile) { | |||
| */ | |||
| private static List<List<String>> getCheckerFrameworkErrors(final String profile) { | |||
| final List<String> checkerFrameworkLines = new ArrayList<>() | |||
| final String command = "mvn -e --no-transfer-progress clean compile -P${profile}" | |||
| final String command = "mvn -e --no-transfer-progress clean compile" | |||
| + " -P${profile},no-validations" | |||
There was a problem hiding this comment.
CI is failing, + has to be on previous line. (It is a groovy thing)
https://github.com/checkstyle/checkstyle/actions/runs/4097261782/jobs/7065502375#step:6:15
There was a problem hiding this comment.
Yes, we should disable this rule one day in future.
There was a problem hiding this comment.
My understanding was that this is something in groovy, not a check we turned on.
https://stackoverflow.com/a/5079914/1016482
There was a problem hiding this comment.
thanks a lot, I just pushed a fix and got surprised that I have no PR
rnveach
force-pushed
the
i12379-checker
branch
from
e3915b2
to
f93c5ce
Compare
|
CI is all green. https://github.com/checkstyle/checkstyle/actions/runs/4116348792/jobs/7106284737#step:6:64 |
rnveach
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12379