Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #13321: Kill mutation for JavadocUtil #13477

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Issue #13321: Kill mutation for JavadocUtil #13477

merged 1 commit into from
Jul 30, 2023

Conversation

Kevin222004
Copy link
Contributor

Issue #13321: Kill mutation for JavadocUtil

Mutation

checkstyle/config/pitest-suppressions/pitest-utils-suppressions.xml

Lines 291 to 299 in bb64c20

<mutation unstable="false">
<sourceFile>JavadocUtil.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.utils.JavadocUtil</mutatedClass>
<mutatedMethod>containsInBranch</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
<description>removed call to com/puppycrawl/tools/checkstyle/api/DetailNode::getParent</description>
<lineContent>curNode = curNode.getParent();</lineContent>
</mutation>

Explaination

Their is no usage of this method in whole codebase

@nrmancuso nrmancuso requested a review from romani July 29, 2023 18:18
@nrmancuso
Copy link
Member

I am good to merge, this is internal utility method.

romani
romani requested changes Jul 30, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal is good.

Items:

config/checker-framework-suppressions/checker-nullness-optional-interning-suppressions.xml Outdated Show resolved Hide resolved
romani
romani approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani assigned rdiachenko and unassigned romani Jul 30, 2023
@romani
Copy link
Member

romani commented Jul 30, 2023

I merging, as we just remove whole method.

@romani romani merged commit 74dc9ef into checkstyle:master Jul 30, 2023
110 of 111 checks passed
@Kevin222004 Kevin222004 mentioned this pull request Oct 24, 2023
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@nrmancuso nrmancuso nrmancuso approved these changes

Assignees

@rdiachenko rdiachenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kevin222004 @nrmancuso @romani @rdiachenko