Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13809: Kill mutation in PackageObjectFactory-2 #13927

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Kevin222004
Copy link
Contributor

@Kevin222004 Kevin222004 commented Oct 22, 2023

Issue #13809: Kill mutation in PackageObjectFactory-2

Test added

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@romani
Copy link
Member

romani commented Oct 31, 2023

CI failure
[ERROR] AllTestsTest.testAllInputsHaveTest:60->walk:87->lambda$testAllInputsHaveTest$1:61->verifyInputFile:156 Resource must start with 'Input' or 'Expected': com/puppycrawl/tools/checkstyle/packageobjectfactory/zoo/FooCheck.java expected to be true

Looks like you need register new test packages at

// until https://github.com/checkstyle/checkstyle/issues/5105
if (!path.contains(File.separatorChar + "grammar" + File.separatorChar)
&& !path.contains(File.separatorChar + "foo" + File.separatorChar)
&& !path.contains(File.separatorChar + "bar" + File.separatorChar)) {

@romani
Copy link
Member

romani commented Oct 31, 2023

[ERROR] [checkstyle] [ERROR] C:\projects\checkstyle\src\test\java\com\puppycrawl\tools\checkstyle\internal\AllTestsTest.java:135:5: Cyclomatic Complexity is 12 (max allowed is 10). [CyclomaticComplexity]

Move IF expression to separate method

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge as CI pass.
Pitest was restarted.

@romani romani merged commit 825a9f8 into checkstyle:master Nov 6, 2023
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants