Issue #14064: Regexp: violation pointing to line 0 while other Checks count first line as 1 #14057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suniti0804
force-pushed
the
regexp
branch
10 times, most recently
from
cf86aa5
to
f20ddcb
Compare
romani
requested changes
Nov 22, 2023
...est/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic2.java
Outdated
Show resolved
Hide resolved
romani
requested changes
Nov 22, 2023
...est/resources/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpSemantic2.java
Outdated
Show resolved
Hide resolved
...urces/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpTrailingComment11.java
Outdated
Show resolved
Hide resolved
suniti0804
force-pushed
the
regexp
branch
3 times, most recently
from
b1abbd8
to
8d89782
Compare
romani
requested changes
Nov 22, 2023
...urces/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpTrailingComment11.java
Outdated
Show resolved
Hide resolved
|
special defect in Check is required to be fixed to let us use good style of test, this migration actaully found a defect in Check pitest will fail, we need to extend test to kill such mutations. After issue is approved we need to change link to issue in commit to new issue, as it is actual fix in Check. |
|
Issue is approved, we need to use new issue in commit as we are fixing defect. https://pitest.org/quickstart/mutators/#NON_VOID_METHOD_CALLS it simply means we do not have test for execution of Check in default mode, good catch. |
romani
changed the title
romani
changed the title
nrmancuso
approved these changes
Nov 28, 2023
|
Ok to merge, CI is restarted |
19 tasks
rnveach
requested changes
Nov 30, 2023
...urces/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpTrailingComment11.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheck.java
Show resolved
Hide resolved
...s/com/puppycrawl/tools/checkstyle/checks/regexp/regexp/InputRegexpStartingWithEmptyLine.java
Outdated
Show resolved
Hide resolved
rnveach
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14064
covers task of Issue #11446