Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: remove concurrency configuration for diff report action #14069

Merged
merged 1 commit into from
Nov 28, 2023
Merged

infra: remove concurrency configuration for diff report action #14069

merged 1 commit into from
Nov 28, 2023

Conversation

nrmancuso
Copy link
Member

Tired of messing with concurrency configuration, seems like Github changed some behavior on their side again. We cannot block diff report generation.

@nrmancuso nrmancuso mentioned this pull request Nov 27, 2023
Closed
@rnveach
Copy link
Member

rnveach commented Nov 27, 2023 

The following Github workflows are missing a concurrency block:
.github/workflows/diff-report.yml

Exited with code exit status 1

@nrmancuso nrmancuso force-pushed the diff-report branch 2 times, most recently from 6fabb21 to 2917e1f Compare November 27, 2023 16:35
romani
romani approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try.

@romani romani closed this Nov 27, 2023
@romani romani reopened this Nov 27, 2023
@romani romani assigned nrmancuso and unassigned romani Nov 27, 2023
@rnveach
Copy link
Member

rnveach commented Nov 28, 2023

Just pointing out CI is still failing as mentioned above.

@romani romani merged commit 22c0361 into checkstyle:master Nov 28, 2023
113 of 114 checks passed
@romani romani mentioned this pull request Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@nrmancuso nrmancuso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nrmancuso @rnveach @romani