Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13213: Remove //ok comments for equalavoidsnull module #14215

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 0 additions & 14 deletions config/checkstyle-input-suppressions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,20 +66,6 @@
files="[\\/]packageobjectfactory[\\/]zoo[\\/]FooCheck.java"/>

<!-- until https://github.com/checkstyle/checkstyle/issues/13213 -->
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]equalsavoidnull[\\/]InputEqualsAvoidNullEnhancedInstanceof.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]equalsavoidnull[\\/]InputEqualsAvoidNullRecordsAndCompactCtors.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]equalsavoidnull[\\/]InputEqualsAvoidNullRecordsAndCompactCtors.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]equalsavoidnull[\\/]InputEqualsAvoidNullRecordsAndCompactCtors.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]equalsavoidnull[\\/]InputEqualsAvoidNullRecordsAndCompactCtors.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]equalsavoidnull[\\/]InputEqualsAvoidNullRecordsAndCompactCtors.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]equalsavoidnull[\\/]InputEqualsAvoidNullTextBlocks.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]coding[\\/]finallocalvariable[\\/]InputFinalLocalVariableCheckRecords.java"/>
<suppress id="UnnecessaryOkComment"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public InputEqualsAvoidNullEnhancedInstanceof(String str) {
if (str instanceof String myString) {
System.out.println("Mystring!!");
boolean myBool = myString.equals("MyString!!"); // violation 'left .* of .* equals'
boolean myOtherBool = myString.equals(str); // ok
boolean myOtherBool = myString.equals(str);
} else if (str instanceof String oneMoreString) {
if(oneMoreString.equals("test")) { // violation 'left .* of .* equals'
System.out.println("Test!!");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class InputEqualsAvoidNullRecordsAndCompactCtors {
record TestRecord1(String str) {
public TestRecord1 {
str.equals("my string"); // violation 'left .* of .* equals'
"my string".equals(str); // ok
"my string".equals(str);
}
}

Expand All @@ -23,7 +23,7 @@ public boolean stringCheck1 (String toCheck){
}

public boolean stringCheck2 (String toCheck){
return "my string".equals(toCheck); // ok
return "my string".equals(toCheck);
}
}

Expand All @@ -32,22 +32,22 @@ record TestRecord3() {
TestRecord3 (String str){
this();
str.equalsIgnoreCase("my string"); // violation 'left .* of .* equalsIgnoreCase'
"my string".equals(str); // ok
"my string".equals(str);
}
}

record TestRecord4(String str) {
public TestRecord4 {
str.equalsIgnoreCase("my string"); // violation 'left .* of .* equalsIgnoreCase'
"my string".equals(str); // ok
"my string".equals(str);
}
}

record TestRecord5() {
TestRecord5 (int num) {
this();
str.equalsIgnoreCase("my string"); // violation 'left .* of .* equalsIgnoreCase'
"my string".equals(str); // ok
"my string".equals(str);
}
private static String str;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ record MyRecord(String a, Object obj) {
System.out.println("this is my other string");
}
else if ("""
one more string""".equals(s)) { // ok
one more string""".equals(s)) {
System.out.println("This is one more string");
}
}
Expand Down