Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #13213: Removed //ok from javadocstyle #14311

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Issue #13213: Removed //ok from javadocstyle #14311

merged 1 commit into from
Jan 20, 2024

Conversation

Tahanima
Copy link
Contributor

@Tahanima Tahanima commented Jan 20, 2024 •
edited
Loading

Part of #13213

Removed //ok comments from the following
  1. InputJavadocStyleCheckOptionLowercaseProperty.java
  2. InputJavadocStyleDefaultSettingsFour.java
  3. InputJavadocStyleDefaultSettingsOne.java
  4. InputJavadocStyleDefaultSettingsThree.java
  5. InputJavadocStyleDefaultSettingsTwo.java
  6. InputJavadocStyleEmptyJavadoc1.java
  7. InputJavadocStyleEmptyJavadoc2.java
  8. InputJavadocStyleEmptyJavadoc3.java
  9. InputJavadocStyleEmptyJavadoc4.java
  10. InputJavadocStyleEnumCtorScopeIsPrivate.java
  11. InputJavadocStyleExcludeScope1.java
  12. InputJavadocStyleExcludeScope2.java
  13. InputJavadocStyleExcludeScope3.java
  14. InputJavadocStyleExcludeScope4.java
  15. InputJavadocStyleFirstSentenceFormatFour.java
  16. InputJavadocStyleFirstSentenceFormatOne.java
  17. InputJavadocStyleFirstSentenceFormatThree.java
  18. InputJavadocStyleFirstSentenceFormatTwo.java
  19. InputJavadocStyleFirstSentenceFour.java
  20. InputJavadocStyleFirstSentenceOne.java
  21. InputJavadocStyleFirstSentenceThree.java
  22. InputJavadocStyleFirstSentenceTwo.java
  23. InputJavadocStyleHtml1.java
  24. InputJavadocStyleHtml2.java
  25. InputJavadocStyleHtml3.java
  26. InputJavadocStyleHtml4.java
  27. InputJavadocStyleHtmlComment.java
  28. InputJavadocStyleInterfaceMemberScopeIsPublic.java
  29. InputJavadocStyleNeverEndingXmlComment.java
  30. InputJavadocStyleNoJavadoc1.java
  31. InputJavadocStyleNoJavadoc2.java
  32. InputJavadocStyleNothing.java
  33. InputJavadocStyleRestrictedTokenSet1.java
  34. InputJavadocStyleRestrictedTokenSet2.java
  35. InputJavadocStyleRestrictedTokenSet3.java
  36. InputJavadocStyleRestrictedTokenSet4.java
  37. InputJavadocStyleScopePackage1.java
  38. InputJavadocStyleScopePackage2.java
  39. InputJavadocStyleScopePackage3.java
  40. InputJavadocStyleScopePackage4.java
  41. InputJavadocStyleScopeProtected1.java
  42. InputJavadocStyleScopeProtected2.java
  43. InputJavadocStyleScopeProtected3.java
  44. InputJavadocStyleScopeProtected4.java
  45. InputJavadocStyleScopePublic1.java
  46. InputJavadocStyleScopePublic2.java
  47. InputJavadocStyleScopePublic3.java
  48. InputJavadocStyleScopePublic4.java

romani
romani approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit c403a9a into checkstyle:master Jan 20, 2024
112 of 113 checks passed
@rnveach rnveach mentioned this pull request Jan 21, 2024
Closed
@Tahanima Tahanima deleted the issue-13213-javadocstyle branch January 21, 2024 10:40
@romani romani mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tahanima @romani