-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14376: Removed Parent POM & Updated maven-release-plugin Config to fix Broken mvn-Enforcer Config #14397
Conversation
Please investigate https://circleci.com/gh/checkstyle/checkstyle/494961 |
@MANISH-K-07 please put this PR into draft mode while you work on resolving failure in release-dry-run, then take it out of draft when ready for review |
This comment was marked as outdated.
This comment was marked as outdated.
6a290d2
to
e86ca15
Compare
This comment was marked as outdated.
This comment was marked as outdated.
We need to understand why before we start trying to change versions in a bunch of dependencies. |
1b9a1af
to
84fd974
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@MANISH-K-07 Please hide all outdated comments as requested in #14397 (comment) now that we have a good summary in the PR description |
This comment was marked as outdated.
This comment was marked as outdated.
Rebased on latest master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets try
Closes #14376
@romani , @nrmancuso
In order to remove the parent pom usage, we needed to apply the parent pom's plugin config. See https://github.com/sonatype/oss-parents/blob/master/codehaus-parent/pom.xml for this configuration.
Without updating this configuration, we get the following error:
We also had failures in the release-dry-run workflow:
org.sonatype.oss oss-parent 9 :