Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14376: Removed Parent POM & Updated maven-release-plugin Config to fix Broken mvn-Enforcer Config #14397

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

MANISH-K-07
Copy link
Contributor

@MANISH-K-07 MANISH-K-07 commented Jan 31, 2024

Closes #14376

@romani , @nrmancuso

In order to remove the parent pom usage, we needed to apply the parent pom's plugin config. See https://github.com/sonatype/oss-parents/blob/master/codehaus-parent/pom.xml for this configuration.

Without updating this configuration, we get the following error:

[ERROR] Project does not define required minimum version of Maven.
[ERROR] Update the pom.xml to contain maven-enforcer-plugin to
[ERROR] force the Maven version which is needed to build this project.

We also had failures in the release-dry-run workflow:

launch (Launcher.java:226)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348)
Caused by: org.apache.maven.plugin.PluginContainerException: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-release-plugin:2.2.1:prepare: java.lang.NoSuchMethodError: 'org.apache.maven.settings.RuntimeInfo org.apache.maven.settings.Settings.getRuntimeInfo()'

org.sonatype.oss oss-parent 9 :

  <!-- This parent is requirements for deploy of artifacts to maven central -->
  <parent>
    <groupId>org.sonatype.oss</groupId>
    <artifactId>oss-parent</artifactId>
    <version>9</version>
  </parent>

@nrmancuso
Copy link
Member

Please investigate https://circleci.com/gh/checkstyle/checkstyle/494961

@nrmancuso
Copy link
Member

@MANISH-K-07 please put this PR into draft mode while you work on resolving failure in release-dry-run, then take it out of draft when ready for review

@MANISH-K-07 MANISH-K-07 marked this pull request as draft February 2, 2024 04:55
@MANISH-K-07

This comment was marked as outdated.

@MANISH-K-07

This comment was marked as outdated.

@nrmancuso
Copy link
Member

@MANISH-K-07

Removing the parent POM is somehow initiating the error with this plugin.

We need to understand why before we start trying to change versions in a bunch of dependencies.

@MANISH-K-07 MANISH-K-07 marked this pull request as ready for review February 2, 2024 14:32
@MANISH-K-07

This comment was marked as outdated.

@MANISH-K-07 MANISH-K-07 changed the title Issue #14376: Resolved Broken MVN-Enforcer Config Issue #14376: Removed Parent POM & Updated maven-release-plugin Config to fix Broken mvn-Enforcer Config Feb 2, 2024
@nrmancuso

This comment was marked as outdated.

@MANISH-K-07

This comment was marked as outdated.

@nrmancuso

This comment was marked as outdated.

@MANISH-K-07

This comment was marked as outdated.

@nrmancuso
Copy link
Member

@MANISH-K-07 Please hide all outdated comments as requested in #14397 (comment) now that we have a good summary in the PR description

@MANISH-K-07

This comment was marked as outdated.

@nrmancuso
Copy link
Member

Rebased on latest master

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try

@romani romani merged commit 974367d into checkstyle:master Feb 27, 2024
112 of 113 checks passed
@MANISH-K-07 MANISH-K-07 deleted the feature branch February 27, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken maven-enforcer configuration
3 participants