Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12923: static imports with method reference reported as unused #14548

Merged
merged 1 commit into from Apr 4, 2024
Merged

Issue #12923: static imports with method reference reported as unused #14548

merged 1 commit into from Apr 4, 2024

Conversation

mahfouz72
Copy link
Member

@mahfouz72
Copy link
Member Author

Github, generate report

@mahfouz72
Copy link
Member Author

Github, generate site

@mahfouz72 mahfouz72 force-pushed the issue-12923-unusedimports branch 2 times, most recently from 31efb52 to 42435df Compare February 25, 2024 18:40
@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/31efb52_2024184149/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/31efb52_2024184149/checks/imports/unusedimports.html#Description

@mahfouz72 mahfouz72 force-pushed the issue-12923-unusedimports branch 2 times, most recently from 792759b to 0a83ff9 Compare February 25, 2024 19:12
@mahfouz72
Copy link
Member Author

Github, generate site

@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/0a83ff9_2024192826/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/0a83ff9_2024192826/checks/imports/unusedimports.html#Description

@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/31efb52_2024202510/reports/diff/index.html

@mahfouz72
Copy link
Member Author

mahfouz72 commented Feb 25, 2024 •
edited

there is something weird here https://checkstyle.semaphoreci.com/jobs/6610b4fd-4eab-445f-b602-99ad27dc56ef is saying that XdocsJavaDocsTest#testAllCheckSectionJavaDocs has an error. but locally the test is passing successfully. I tried to rerun CI multiple times and still got this error. also mvn verify passed

@nrmancuso nrmancuso self-requested a review February 26, 2024 23:55
@nrmancuso nrmancuso self-assigned this Feb 26, 2024
nrmancuso
nrmancuso reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make changes to the .template files, which are used to generate the normal xdocs:

  1. Update template blah.template.xml files
  2. Run mvn clean verify
  3. Commit generated xdoc content

@mahfouz72
Copy link
Member Author

@nrmancuso yes. I missed it Thank you! now CI is happy

@nrmancuso
Copy link
Member

Github, generate site

@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6717c08_2024231552/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6717c08_2024231552/checks/imports/unusedimports.html#Description

nrmancuso
nrmancuso requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend code examples in documentation to include this update.

Items:

...style/checks/imports/unusedimports/InputUnusedImportsFromStaticMethodRefJavadocDisabled.java Outdated Show resolved Hide resolved
...s/checkstyle/checks/imports/unusedimports/InputUnusedImportsFromStaticMethodRefExtended.java Show resolved Hide resolved
@mahfouz72 mahfouz72 force-pushed the issue-12923-unusedimports branch 2 times, most recently from 866ab0d to 541850e Compare February 28, 2024 01:04
@nrmancuso
Copy link
Member

@mahfouz72 please do

Please extend code examples in documentation to include this update.

From #14548 (review)

@mahfouz72 mahfouz72 force-pushed the issue-12923-unusedimports branch 5 times, most recently from 2f050e4 to 0c79a63 Compare February 28, 2024 09:33
@rnveach rnveach assigned rnveach and unassigned romani Mar 19, 2024
@mahfouz72
Copy link
Member Author

Github, generate site

@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/1e68d3c_2024015607/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/1e68d3c_2024015607/checks/imports/unusedimports.html#Description

@mahfouz72 mahfouz72 mentioned this pull request Mar 20, 2024
Open
@rnveach
Copy link
Member

rnveach commented Mar 27, 2024

CI is failing.

The PR is based on a master that is 17 commit(s) old.
The max allowed is 10.
This PR is too old and should be rebased on origin/master.

@mahfouz72
Copy link
Member Author

@rnveach done

romani
romani requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

...awl/tools/checkstyle/checks/imports/unusedimports/InputUnusedImportsFromStaticMethodRef.java Show resolved Hide resolved
@rnveach rnveach assigned romani and unassigned rnveach Mar 29, 2024
@romani
Copy link
Member

romani commented Apr 1, 2024

@mahfouz72 , please rebase.
please reply at
#14548 (comment)

@mahfouz72
Copy link
Member Author

Github, generate site

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/d1974a0_2024140754/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/d1974a0_2024140754/checks/imports/unusedimports.html#Description

@mahfouz72
Copy link
Member Author

@romani rebased on latest master

@mahfouz72
Copy link
Member Author

Github, generate site

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c602744_2024142930/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c602744_2024142930/checks/imports/unusedimports.html#Description

romani
romani requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last:

src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheck.java Outdated Show resolved Hide resolved
@mahfouz72
Copy link
Member Author

Github, generate site

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5371b69_2024174640/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/5371b69_2024174640/checks/imports/unusedimports.html#Description

romani
romani approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for hard work

@romani romani merged commit f7e952b into checkstyle:master Apr 4, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@rnveach rnveach rnveach approved these changes

@nrmancuso nrmancuso nrmancuso approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mahfouz72 @nrmancuso @rnveach @romani