Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14123: Exclude google-collections from doxia-module-xdoc #14669

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

lukasgraef
Copy link
Contributor

Fixes Issues #14123 and #14211 by also excluding google-collections from doxia-module-xdoc.

A previous fix (#14140) removed google-collections from doxia-core, but doxia-module-xdoc also contains google-collections as a transitive dependency.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge if CI pass (Cirrus failure is expected and unfortunate)

@lukasgraef , did you check that it help in your gradle build ?

if yes, I can release fix today, to ease problem for all others. We still not able to reproduce problems on some opensource project.

@romani romani merged commit 01d63bf into checkstyle:master Mar 16, 2024
112 of 113 checks passed
@romani
Copy link
Member

romani commented Mar 16, 2024

I am starting release 10.14.2

@romani
Copy link
Member

romani commented Mar 17, 2024

@romani
Copy link
Member

romani commented Mar 17, 2024

I found how to reproduce this problem.
this update/PR and 10.14.2 fixed it, tested at #14211 (comment)

@XN137
Copy link
Contributor

XN137 commented Mar 18, 2024

afaict this fix was required because doxia-module-xdoc also depends on doxia-core itself.

some things to consider:

a) we should probably prefer using <dependencyManagement> for doing these exclusions to affect all transitive usage of doxia-core (i basically had this in my original suggestion but was asked to change to a specific exclusion during review
this is of course assuming that gradle respects that tag the same way maven does.

b) the exclusion of commons-codec above is not respected when doxia-core is pulled in again by doxia-module-xdoc (might be another argument for using <dependencyManagement>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants