Issue #6981: IT regression area input files Suppressed & Pattern validation updated to "InputXpath{Checkname}Xxx.java" #14713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MANISH-K-07
force-pushed
the
InputXpath
branch
3 times, most recently
from
c0b0db6
to
de281f8
Compare
MANISH-K-07
commented
Mar 24, 2024
| @@ -117,6 +117,149 @@ public class XpathRegressionTest extends AbstractModuleTestSupport { | |||
|
|
|||
| private static final Set<String> INTERNAL_MODULES = getInternalModules(); | |||
|
|
|||
| // Checks whose files need to be renamed to new pattern "InputXpath{Check}Xxx.java" | |||
| // till checkstyle issue | |||
| private static final Set<String> RENAME_INPUT_XPATH = Set.of( | |||
There was a problem hiding this comment.
We are then good to completely swap old enforcement with new as it will be fixed as your list is worked on. The list must reference the issue to work on (until https://....) and complete it. I recommend to make this a new issue, we can mark it as easy
After your confirmation, I will create a new issue as suggested at #14595 (comment) and update comment above
rnveach
approved these changes
Mar 24, 2024
Sorry I closed and reopened by mistake.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to close #6981
PR not ready for review !!I was facing issues with mvn validations on local. So, please excuse me while I use our integration workflows for verifying
Update : The pattern has been updated at
XpathRegressionTest#validateInputDirectoryto validate "InputXpath{Checkname}Xxxx.java". All existing old named modules have been suppressed.<--Unrelated-->
Fun fact : Our IDEs have this keyboard shortcut
ctrl+shift+zto single-line comment the line on which cursor is 馃槃