Issue #14715: Enforced new naming convention in IT area 16 #14795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MANISH-K-07
force-pushed
the
naming16
branch
2 times, most recently
from
92e8c0e
to
5b79be4
Compare
romani
reviewed
Apr 15, 2024
| @@ -63,7 +63,7 @@ public void testOne() throws Exception { | |||
| @Test | |||
| public void testTwo() throws Exception { | |||
There was a problem hiding this comment.
Do you plan to fix such names to match input suffix?
There was a problem hiding this comment.
Or better to do this in separate PR ? I think so
There was a problem hiding this comment.
@romani , in fact I've been changing respective test method names too in these PRs itself.. (#14795 (comment))
The problem with a few input files is that there is no proper design on how they have been introduced to our code by the authors. I'm unable to come up with meaningful suffixes for such files, and am leaving those abstract (One, Two, ....)
Rest assured, the input file suffixes and test names, I always make sure they match.
Even here, testTwo because it takes file InputXpathIllegalTypeTwo
romani
approved these changes
Apr 15, 2024
MANISH-K-07
commented
Apr 15, 2024
src/it/java/org/checkstyle/suppressionxpathfilter/XpathRegressionInterfaceIsTypeTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14715