New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #13345: Enabled MutableExceptionCheckExamplesTest #14796
Conversation
Initial PR was giving too many conflicts. In this PR I have followed the guidelines given in this. I will make sure such mistakes don't happen again from my side |
} | ||
} | ||
|
||
class FirstMyException extends Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'My' here is redundant and looks weird. Please change FirstMyException
--> FirstException
Same for all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Prathamesh-007 , please squash and rebase to single commit
d3c224b
to
2412c35
Compare
2412c35
to
05a6b49
Compare
Done |
GitHub, generate website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
Begin #13345:
Enabled MutableExceptionCheckExamplesTest.java