Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: update check-performance-regression.yml to have no extra folder #14851

Merged
merged 1 commit into from
May 3, 2024

Conversation

romani
Copy link
Member

@romani romani commented May 3, 2024

https://github.com/checkstyle/checkstyle/actions/runs/8934444831/job/24541391465?pr=14779#step:6:9

0s
Run cd checkstyle
  cd checkstyle
  bash ./.ci/check-performance-regression.sh
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.22-7/x64
    JAVA_HOME_11_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.22-7/x64
bash: ./.ci/check-performance-regression.sh: No such file or directory

@romani
Copy link
Member Author

romani commented May 3, 2024

https://github.com/checkstyle/checkstyle/actions/runs/8939370455/job/24555267920?pr=14851#step:6:339

not failing but:

Benchmark launching...
================ MOST RECENT COMMAND RESULT =================
Files to process must be specified, found 0.
===================== BENCHMARK SUMMARY ====================
Execution Time Baseline: 415.72 s
Average Execution Time: .26 s
============================================================
Execution Time Difference: -99.9300%
Difference is within the maximum allowed difference (-99.9300%      <= 10%).

we need to merge to unblock other PRs, and fix it in separte PR.

@nrmancuso nrmancuso mentioned this pull request May 3, 2024
@nrmancuso
Copy link
Member

#14852

@nrmancuso nrmancuso merged commit 90cac43 into master May 3, 2024
107 of 115 checks passed
@nrmancuso nrmancuso deleted the romani-patch-1 branch May 3, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants