Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: makes links relative for version documentation #14876

Merged
merged 1 commit into from
May 15, 2024
Merged

doc: makes links relative for version documentation #14876

merged 1 commit into from
May 15, 2024

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented May 14, 2024 •
edited

Ensure we stay in version documentation.

This also applies to GH website generation.

@rnveach

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@rnveach
Copy link
Member Author

rnveach commented May 14, 2024

GitHub, generate website

@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b1bdd73_2024174153/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b1bdd73_2024174153/anttask.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b1bdd73_2024174153/cmdline.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b1bdd73_2024174153/sun_style.html#Sun_Useful_information

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/b1bdd73_2024174153/writingjavadocchecks.html#

@rnveach rnveach marked this pull request as ready for review May 15, 2024 02:37
romani
romani approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked ant, it works

@romani romani requested a review from nrmancuso May 15, 2024 13:20
@nrmancuso
Copy link
Member

Thanks for noticing this @rnveach

@nrmancuso nrmancuso merged commit 2d172f3 into checkstyle:master May 15, 2024
114 checks passed
@rnveach rnveach deleted the links branch May 15, 2024 13:43
@rnveach rnveach mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@nrmancuso nrmancuso nrmancuso approved these changes

Assignees

@nrmancuso nrmancuso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnveach @nrmancuso @romani