Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14877: drop java 14 build #14886

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

strkkk
Copy link
Member

@strkkk strkkk commented May 20, 2024

Closes #14877

~/IdeaProjects/checkstyle (14877_drop_java14)
$ grep -Rl --include='*.java' ': Compilable with Java14' | wc -l
0

~/IdeaProjects/checkstyle (14877_drop_java14)
$ grep -Rl --include='*.java' ': Compilable with Java17' | wc -l
242

@strkkk strkkk force-pushed the 14877_drop_java14 branch 8 times, most recently from 107aeb1 to 7037743 Compare May 21, 2024 01:08
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge.

My confusion was on line where javac error.

src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/checks/coding/equalsavoidnull/InputEqualsAvoidNullEnhancedInstanceof.java:13: error: expression type String is a subtype of pattern type String
        if (str instanceof String myString) {
                ^

I still cannot expalin why 206cb0d
is passing
https://app.circleci.com/pipelines/github/checkstyle/checkstyle/25600/workflows/eab6c959-c9a9-44a1-a34b-5b3d0bcdea67/jobs/593792
but it is ok, may be I am blind.

@nrmancuso nrmancuso merged commit 15e0c7e into checkstyle:master May 26, 2024
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop ci jobs for unsupported java versions
3 participants