Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14911: Added a new section 4.8.5.3 in google style guide implementation #14982

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Zopsss
Copy link
Contributor

@Zopsss Zopsss commented Jun 13, 2024

issue #14911

added a new section 4.8.5.3 Methods And Constructors Annotations in google style guide coverage page and wrote test cases for it

@Zopsss Zopsss force-pushed the section-4853 branch 2 times, most recently from a374924 to 63ecdc0 Compare June 13, 2024 11:47
@Zopsss
Copy link
Contributor Author

Zopsss commented Jun 13, 2024

GitHub, generate site

@Zopsss
Copy link
Contributor Author

Zopsss commented Jun 13, 2024

website looks fine

@rdiachenko rdiachenko self-assigned this Jun 13, 2024
@Zopsss Zopsss force-pushed the section-4853 branch 2 times, most recently from 859ba58 to f827148 Compare June 14, 2024 05:16
Copy link
Contributor

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko assigned romani and unassigned rdiachenko Jun 14, 2024
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

@Zopsss Zopsss force-pushed the section-4853 branch 2 times, most recently from b0dd2d6 to 40dc580 Compare June 16, 2024 18:25
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge

@romani romani merged commit 7cbfef2 into checkstyle:master Jun 17, 2024
111 checks passed
@Zopsss Zopsss deleted the section-4853 branch June 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants