Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13345: Enabled SingleLineJavadoc example tests #14992

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

SteLeo1602
Copy link
Contributor

Issue: #13345

Enabled the example tests for SingleLineJavadoc check.

@romani
Copy link
Member

romani commented Jun 15, 2024

@SteLeo1602 , please always look at failures of CI yourself and try to fix
https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/50024700/job/vau4qharfqaj7223#L111
order of imports should be fixed.

@SteLeo1602
Copy link
Contributor Author

@SteLeo1602 , please always look at failures of CI yourself and try to fix https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/50024700/job/vau4qharfqaj7223#L111 order of imports should be fixed.

I save the rest of need-to-fix portion of the pull request for tomorrow when I run out of available time for the day. But I definitely look and try to understand it myself first when I'm working again.

@romani
Copy link
Member

romani commented Jun 16, 2024

Let me know if need help here.

@SteLeo1602
Copy link
Contributor Author

GitHub, generate website

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item

@SteLeo1602
Copy link
Contributor Author

GitHub, generate website

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if CI pass

@romani romani merged commit 4fe32fc into checkstyle:master Jun 20, 2024
111 checks passed
@SteLeo1602 SteLeo1602 deleted the EnableSingleLineJavadoc branch June 25, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants