Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #13345: Enabled SeverityMatch example tests #14993

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Issue #13345: Enabled SeverityMatch example tests #14993

merged 1 commit into from
Jun 17, 2024

Conversation

SteLeo1602
Copy link
Contributor

Issue: #13345

Enabled the example tests for SeverityMatch check.

romani
romani requested changes Jun 16, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item

...examples/resources/com/puppycrawl/tools/checkstyle/filters/severitymatchfilter/Example1.java Outdated
public class Example1 {
public void method1(int V1){} // ok, ParameterNameCheck's severity is info

public void Method2(){} // violation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put violation message here, it is not clear from what check violation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@romani
Copy link
Member

romani commented Jun 16, 2024

GitHub, generate website

@SteLeo1602 SteLeo1602 force-pushed the EnableSeverityMatch branch 2 times, most recently from be1904c to 847c58f Compare June 17, 2024 03:56
@SteLeo1602
Copy link
Contributor Author

GitHub, generate website

@github-actions GitHub Actions
Copy link
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/26826cb_2024043208/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/26826cb_2024043208/filters/severitymatchfilter.html#Example1-config

romani
romani approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 8408c30 into checkstyle:master Jun 17, 2024
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahfouz72 mahfouz72 mahfouz72 left review comments

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SteLeo1602 @romani @mahfouz72