Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 10. Java 8 syntax support has been added #226

Merged
merged 15 commits into from
Oct 10, 2014
Merged

Conversation

sabaka
Copy link
Contributor

@sabaka sabaka commented Aug 7, 2014

Now it can support default methods, methods references, new type cast and lambdas.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2a88320 on sabaka:gsoc into 3a51c61 on checkstyle:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2a88320 on sabaka:gsoc into 3a51c61 on checkstyle:master.

@romani romani self-assigned this Aug 12, 2014
@tonyghita
Copy link

Any word on when this will be released? It's a highly anticipated feature for me :)

@romani
Copy link
Member

romani commented Aug 13, 2014

@tonyghita, #10 (comment)

@tonyghita
Copy link

👍

@romani
Copy link
Member

romani commented Aug 13, 2014

mean while please do build yourself "mvn -Pdistro package" and provide us feedback after testing over your sources.

@ayadav77
Copy link

I tried this pull request locally against my code base. It seems to handle the Java 8 features like lambda expressions correctly now. But It is failing on recognizing custom annotations. I get the following exception for all custom annotations that i have defined in my codebase:

MyCustomAnnotation.java:0: Got an exception - java.lang.StringIndexOutOfBoundsException: String index out of range: -1

@ayadav77
Copy link

Please ignore the above comment. The exception java.lang.StringIndexOutOfBoundsException: String index out of range: -1 is occurring in one of the custom Checks that exists in our codebase. I will troubleshoot further and provide any additional information that may be relevant here.

@ayadav77
Copy link

My testing of this pull request has been successful. I had to ensure that my custom checks were compiled against the new checkstyle jar (of course). I successfully was able to have checkstyle perform the analysis on my java 8 codebase.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling 33bdc2b on sabaka:gsoc into 4e213f5 on checkstyle:master.

@tuan-pham
Copy link

Hi guys,
Is there anyone try to run this release in Gradle.
I tried but couldn't run the Checkstyle.SNAPSHOT.jar with Checkstyle plugin in Gradle. Any ideas?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling 6bbb283 on sabaka:gsoc into f43e7ca on checkstyle:master.

@romani
Copy link
Member

romani commented Sep 16, 2014

build is failed

[ERROR] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/TokenTypes.java:3435: error: bad use of '>'
[ERROR] * "->" lambda specifying symbol.

have to be fixed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling 1333765 on sabaka:gsoc into f43e7ca on checkstyle:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling ad0df4d on sabaka:gsoc into a4e79cf on checkstyle:master.

@sabaka
Copy link
Contributor Author

sabaka commented Sep 17, 2014

@romani, fixed.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f2ccdda on sabaka:gsoc into a4e79cf on checkstyle:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 2685c8e on sabaka:gsoc into a4e79cf on checkstyle:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 90c392d on sabaka:gsoc into a4e79cf on checkstyle:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 90c392d on sabaka:gsoc into a4e79cf on checkstyle:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 29fd271 on sabaka:gsoc into a4e79cf on checkstyle:master.

@tonyghita
Copy link

I'm so excited for this release 👍 💯

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling dcef0fe on sabaka:gsoc into 0687461 on checkstyle:master.

@sabaka sabaka force-pushed the gsoc branch 4 times, most recently from 2e80d24 to ba05b26 Compare October 10, 2014 10:49
@sabaka sabaka force-pushed the gsoc branch 2 times, most recently from 8b52eb4 to cec50f8 Compare October 10, 2014 17:14
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling cec50f8 on sabaka:gsoc into 95f3a80 on checkstyle:master.

@romani romani merged commit ed5f8a4 into checkstyle:master Oct 10, 2014
@romani
Copy link
Member

romani commented Oct 10, 2014

merged ! THANKS A LOT !

@daniilyar
Copy link
Contributor

Great work, Ilja! Thank you a lot =)

@tonyghita
Copy link

I'd like to second @daniilyar, great work! Thank you so much

@sabaka sabaka deleted the gsoc branch September 3, 2015 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants