Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3487: turned on checkstyle cache for developers #3565

Merged
merged 1 commit into from Nov 20, 2016

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Nov 19, 2016

Issue #3487

Cache turned on for Checkstyle and sevntu.

  • Changes in XDocPagesTest is because instantiating the examples caused our own cachefile to be corrupted.
  • Sevntu cachefile couldn't be enabled in the pom, that I could figure out. <cacheFile>${project.build.directory}/cachefile-sevntu</cacheFile> caused no cache file to be created.
  • Removed the delete cachefiles as we don't really need them and will defeat the purpose of the cache. CI will always be clean, so it will only matter locally. Cache is deleted on clean, and will reset for files/configs that change. Deleting the file will just put us back without cache each time we run verify.

@codecov-io
Copy link

Current coverage is 99.59% (diff: 100%)

Merging #3565 into master will not change coverage

@@             master      #3565   diff @@
==========================================
  Files           275        275          
  Lines         13311      13311          
  Methods           0          0          
  Messages          0          0          
  Branches       3035       3035          
==========================================
  Hits          13257      13257          
  Misses           53         53          
  Partials          1          1          

Powered by Codecov. Last update 0e8c819...9806a3c

@romani
Copy link
Member

romani commented Nov 20, 2016

Sevntu cachefile couldn't be enabled in the pom, that I could figure out

issue created against maven by you for cache: https://issues.apache.org/jira/browse/MCHECKSTYLE-332

@romani romani merged commit 6f82844 into checkstyle:master Nov 20, 2016
@rnveach rnveach deleted the issue_3487 branch November 20, 2016 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants