Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3721: expanded message and documentation AbbreviationAsWordInName #3827

Merged
merged 2 commits into from Feb 17, 2017

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Feb 13, 2017

Issue #3721

@codecov-io
Copy link

codecov-io commented Feb 13, 2017

Codecov Report

Merging #3827 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3827   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         275     275           
  Lines       13636   13643    +7     
  Branches     3070    3070           
======================================
+ Hits        13636   13643    +7
Impacted Files Coverage Δ
.../checks/indentation/AbstractExpressionHandler.java 100% <ø> (ø)
...heckstyle/checks/metrics/NPathComplexityCheck.java 100% <ø> (ø)
...ls/checkstyle/checks/indentation/SlistHandler.java 100% <ø> (ø)
...s/checkstyle/checks/indentation/SwitchHandler.java 100% <ø> (ø)
...checkstyle/checks/indentation/ClassDefHandler.java 100% <ø> (ø)
...yle/checks/AvoidEscapedUnicodeCharactersCheck.java 100% <100%> (ø)
...ols/checkstyle/gui/ParseTreeTablePresentation.java 100% <100%> (ø)
...style/filters/SuppressWithNearbyCommentFilter.java 100% <100%> (ø)
...ckstyle/checks/indentation/ObjectBlockHandler.java 100% <100%> (ø)
...ckstyle/checks/indentation/BlockParentHandler.java 100% <100%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa8bcf...8a225e7. Read the comment docs.

@rnveach
Copy link
Member Author

rnveach commented Feb 13, 2017

Shippable failure is a timeout.

@rnveach
Copy link
Member Author

rnveach commented Feb 15, 2017

I will suppress JTreeTable as this is a Java convention for javax.swing

That is not our convention. Nothing force us to keep name that similar to java standard. Lets avoid illusions.
Lets avoid suppressions, rename it to what ever is more reasonable.

Done.

@romani
Copy link
Member

romani commented Feb 17, 2017

/api/FileContents.java

we can not change API now, please make new methods with correct names to use in our code.
old api methods should call new methods.
old api methods should be marked as deprecated, they will be removed in checkstyle8.

@rnveach
Copy link
Member Author

rnveach commented Feb 17, 2017

old api methods should call new methods.
old api methods should be marked as deprecated, they will be removed in checkstyle8.

Done.
Had to make 1 new test to get code coverage in FileContents for the deprecated methods.

@romani romani merged commit 6e8d1e0 into checkstyle:master Feb 17, 2017
@rnveach rnveach deleted the issue_3721 branch February 17, 2017 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants