Issue #3959: Split and Organize Checkstyle inputs by Test for FileTabCharacter #4182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4182 +/- ##
======================================
Coverage 100% 100%
======================================
Files 283 283
Lines 14880 14880
Branches 3401 3401
======================================
Hits 14880 14880Continue to review full report at Codecov.
|
| @@ -56,9 +58,9 @@ public void testDefault() throws Exception { | |||
| "19:25: " + getCheckMessage(MSG_FILE_CONTAINS_TAB), | |||
| }; | |||
| final File[] files = { | |||
| new File(getPath("InputSimple.java")), | |||
| new File(getPath("SimpleFileTabCharacterInput.java")), | |||
There was a problem hiding this comment.
Input files should be named after their tests.
FileTabCharacterCheckTest's inputs should be named InputFileTabCharacter....
| * - Order of modifiers | ||
| * @author Oliver Burn | ||
| **/ | ||
| final class SimpleFileTabCharacterInput |
There was a problem hiding this comment.
input classes must match file name.
There was a problem hiding this comment.
Recently I made a commit with appropriate changes
There was a problem hiding this comment.
@Kietzmann This is still not done.
|
@Kietzmann , please squash all commits in one for final review. |
Kietzmann
force-pushed
the
3959
branch
2 times, most recently
from
e02c20b
to
8ae939d
Compare
|
@rnveach |
|
@Kietzmann Please, write a proper commit message, |
|
@Vladlis |
|
@Kietzmann |
Kietzmann
force-pushed
the
3959
branch
2 times, most recently
from
0c6d1c1
to
15a17fd
Compare
|
Ups... |
|
@Kietzmann Now you need to rebase on the latest master. When you squashed the commits, somehow you added commits that were not your own so now you have changes outside of |
…or FileTabCharacter
|
@rnveach Seems to be fixed |
This pull request covers to issue #3959
What was modified:
Modified paths to test classes
Moved all necessary inputs into /whitespace/filltabcharacter package
Results:
All unit tests passed.
the result of mvn clean verify also OK