Issue #4431: Modified ModifierOrderCheckTest.java and moved its input files to the modifierorder subdirectory #4432
Conversation
| @@ -68,7 +68,7 @@ public void testIt() throws Exception { | |||
| "49:35: " + getCheckMessage(MSG_ANNOTATION_ORDER, "@MyAnnotation4"), | |||
| "157:14: " + getCheckMessage(MSG_MODIFIER_ORDER, "default"), | |||
| }; | |||
| verify(checkConfig, getPath("InputModifier.java"), expected); | |||
| verify(checkConfig, getPath("InputModifierIt.java"), expected); | |||
There was a problem hiding this comment.
Test is named ModifierOrderCheckTest so files must start with InputModifierOrder.
Please change.
All inputs for this class should follow the pattern. I see others that aren't.
Class names of inputs should also be the same as file name.
There was a problem hiding this comment.
I will change it accordingly but for very small files the change might result in deletion and creation when I commit and not a rename. Is that ok?
Codecov Report
@@ Coverage Diff @@
## master #4432 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 285 285
Lines 15297 15297
Branches 3482 3482
=======================================
Hits 15296 15296
Partials 1 1Continue to review full report at Codecov.
|
subkrish
force-pushed
the
fix-issue-4431-modifierorder
branch
from
da60edc
to
924366f
Compare
… its input files to the modifierorder subdirectory
subkrish
force-pushed
the
fix-issue-4431-modifierorder
branch
from
924366f
to
d70ecf1
Compare
Issue #4431
This PR moves all inputs of ModifierOrderCheckTest of the modifier package to a new subdirectory 'modifierorder'.