Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: added heap size to surefire to fix travis failures #4487

Merged
merged 1 commit into from Jun 22, 2017

Conversation

@rnveach
Copy link
Member Author

rnveach commented Jun 22, 2017

2 runs in my own travis are passing with this change:
https://travis-ci.org/rnveach/checkstyle/builds/245777457
https://travis-ci.org/rnveach/checkstyle/builds/245789540
I did confirm failures before going forward with fix:
https://travis-ci.org/rnveach/checkstyle/builds/245771516

@romani romani merged commit 47026a6 into checkstyle:master Jun 22, 2017
@rnveach rnveach deleted the test_issue_4316_fix branch June 22, 2017 14:15
@romani
Copy link
Member

romani commented Jun 22, 2017

I merged, but we need to find way to move that arguments to command line of Travis commands as it Travis problem, comment should be extended to have a reference to issue that we are fixing

@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #4487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4487   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         285     285           
  Lines       15325   15325           
  Branches     3489    3489           
======================================
  Hits        15325   15325

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fcfb0...180a76a. Read the comment docs.

@romani
Copy link
Member

romani commented Jun 22, 2017

We also need to restore ignored tests in localized launches

Ahaochan added a commit to Ahaochan/ahao-common-utils that referenced this pull request Jul 31, 2020
Ahaochan added a commit to Ahaochan/project that referenced this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants