Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4534: add ANNOTATION_DEF to defaultTokens to fix NPE #4535

Merged
merged 1 commit into from Jun 27, 2017

Conversation

romani
Copy link
Member

@romani romani commented Jun 27, 2017

Issue #4534

@rnveach , please review and merge if you agree.
regression could be provided later, we need to unblock wercker.

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #4535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4535   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         285     285           
  Lines       15333   15333           
  Branches     3494    3494           
======================================
  Hits        15333   15333
Impacted Files Coverage Δ
...ools/checkstyle/checks/sizes/MethodCountCheck.java 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ae053...d50f9ec. Read the comment docs.

@rnveach
Copy link
Member

rnveach commented Jun 27, 2017

@romani Shouldn't we look at regression?

@romani
Copy link
Member Author

romani commented Jun 27, 2017

@rnveach, just planned to merge it sooner to avoid forcing all PR to rebase. Current implementation will not be very different even smth is found during testing.

@rnveach rnveach merged commit 7956f0b into master Jun 27, 2017
@rnveach
Copy link
Member

rnveach commented Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants