Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4725: add inspections passed without violations #4729

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Nimfadora
Copy link
Contributor

@Nimfadora Nimfadora commented Jul 16, 2017

Issue #4725

enabled such inspections:
AssertMessageNotString
CheckStyle
CollectionAddAllCanBeReplacedWithConstructor
CssConvertColorToRgbInspection
CssUnusedSymbol
DanglingJavadoc
ExtendsThrowable
FieldAccessedSynchronizedAndUnsynchronized
FieldRepeatedlyAccessed
FunctionWithMultipleLoopsJS
Guava
GuavaFluentIterable
HtmlUnknownTarget
IgnoreDuplicateEntry
IgnoreRelativeEntry
IgnoreUnusedEntry
JSDeclarationsAtScopeStart
MethodNamesDifferOnlyByCase
MethodOnlyUsedFromInnerClass
PackageNamingConvention
PackageVisibleField
RedundantMethodOverride
ResultOfObjectAllocationIgnored
StaticNonFinalField
UnusedParameters

@romani
Copy link
Member

romani commented Jul 20, 2017

Please rebase this PR to have actual state of what is left

@Nimfadora
Copy link
Contributor Author

@romani renewed report. Some of idea checks that I enabled does not invoke any violations, I will leave them enabled?, yes?

@romani
Copy link
Member

romani commented Jul 20, 2017

I will leave them enabled?, yes?

yes, if no problems found in our code - keep them enabled.

@romani romani merged commit e0b8606 into checkstyle:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants