Issue #4846: ignore annotation in enum constructor for RedundantModifier #4902
Conversation
| while (modifier != null && modifier.getType() == TokenTypes.ANNOTATION) { | ||
| modifier = modifier.getNextSibling(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Logic is not easy to understand, why first modifier is not modifier :) , it might be better to make method getFirstModifierAst() in this class, one day it will be moved to common Util class.
Codecov Report
@@ Coverage Diff @@
## master #4902 +/- ##
======================================
Coverage 100% 100%
======================================
Files 287 287
Lines 15489 15493 +4
Branches 3518 3519 +1
======================================
+ Hits 15489 15493 +4
Continue to review full report at Codecov.
|
|
Regression: http://rveach.no-ip.org/checkstyle/regression/reports/97/ Showed no differences. |
|
as CI pass - ok to merge. |
|
@romani ping |
|
@rnveach , as you see my approval for merge, and condition is satisfied (all CIs are green) - you can merge PR yourself. |
Issue #4846
Regression to come.