Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5027: remove use of javax.xml.bind.DatatypeConverter #5028

Closed
wants to merge 1 commit into from
Closed

Issue #5027: remove use of javax.xml.bind.DatatypeConverter #5028

wants to merge 1 commit into from

Conversation

osiegmar
Copy link
Contributor

Issue #5027

This change replaces javax.xml.bind.DatatypeConverter with com.google.common.io.BaseEncoding

@osiegmar
remove use of javax.xml.bind.DatatypeConverter
a3a3714 
JDK 9 marks the package (module) java.xml.bind as deprecated for removal.
More dramatically, the current use in Checkstyle results in a NoClassDefFoundError/ClassNotFoundException if java weren't started with the --add-modules java.xml.bind parameter.

This change replaces javax.xml.bind.DatatypeConverter with com.google.common.io.BaseEncoding
@romani
Copy link
Member

romani commented Aug 30, 2017

@osiegmar , thanks a lot.

CI will fail, please change commit message to reference issue number, like "Issue #5027: ...." ,commit message should be single line, less then 200 symbols. All details should be in issue or PR.

@osiegmar osiegmar changed the title Pull #5027: remove use of javax.xml.bind.DatatypeConverter Issue #5027: remove use of javax.xml.bind.DatatypeConverter Aug 30, 2017
@osiegmar osiegmar closed this Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@osiegmar @romani