Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5094: delete javadoc.parse.error #5238

Merged
merged 1 commit into from Oct 28, 2017
Merged

Issue #5094: delete javadoc.parse.error #5238

merged 1 commit into from Oct 28, 2017

Conversation

dyominov
Copy link
Contributor

Issue #5094: delete javadoc.parse.error

@codecov-io
Copy link

codecov-io commented Oct 26, 2017

Codecov Report

Merging #5238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5238   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         296     296           
  Lines       16097   16097           
  Branches     3664    3664           
======================================
  Hits        16097   16097
Impacted Files Coverage Δ
...heckstyle/checks/javadoc/AbstractJavadocCheck.java 100% <ø> (ø) ⬆️
...rawl/tools/checkstyle/JavadocDetailNodeParser.java 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cbb54...2ff3b5c. Read the comment docs.

@rnveach
Copy link
Member

rnveach commented Oct 26, 2017

@dyominov you do not need to keep closing and creating new PRs to submit changes.
Just amend your changes, force push to your branch and github will see the changes and respond accordingly.

@rnveach
Copy link
Member

rnveach commented Oct 26, 2017

@dyominov Please squash your commits into just 1 commit and keep it at 1.
See https://github.com/checkstyle/checkstyle/wiki/PR-rules point 2 on how to do it if you don't know.

@romani
Copy link
Member

romani commented Oct 26, 2017

ones it become single commit, I am ok to merge.

@dyominov
Copy link
Contributor Author

@rnveach Thaks for help, I'm sorry didn't see before this rules and sorry for closed pool.
@romani Sorry for many commits i fix it.

@rnveach
Copy link
Member

rnveach commented Oct 26, 2017

@dyominov Please don't push until you are sure you have removed the commits.
Your commit count is up to 7, so it will be clear in your history view if you have fixed it.

@dyominov
Copy link
Contributor Author

@rnveach I try rebase , but my push not change previous commits, only add new

@dyominov dyominov closed this Oct 26, 2017
@dyominov dyominov reopened this Oct 26, 2017
@dyominov
Copy link
Contributor Author

dyominov commented Oct 27, 2017

In build Shippable i take errors
<Error> <Code>AccessDenied</Code> <Message>Request has expired</Message> <X-Amz-Expires>600</X-Amz-Expires> <Expires>2017-10-26T23:42:21Z</Expires> <ServerTime>2017-10-26T23:54:03Z</ServerTime> <RequestId>3B6B63A286FF2D1E</RequestId> <HostId> 4ZgVw3CYPryPGC7y++u1Lm4fwfsSOP7j0pEdBoCtKWK2Jd1f218NWAgDsv1mtJsx9MlefL+/Luk= </HostId> </Error>
and
<Error> <Code>AccessDenied</Code> <Message>Request has expired</Message> <X-Amz-Expires>600</X-Amz-Expires> <Expires>2017-10-26T23:42:21Z</Expires> <ServerTime>2017-10-26T23:51:37Z</ServerTime> <RequestId>5F228DB06FC1B7C4</RequestId> <HostId> HOdiJyyYJXJmOFCYtqXzGThISfWhAQpd+qgweWNhcGNjublI6eyh3D/dfKS/C6kg55uhBjPjmEM= </HostId> </Error>

How I can fix it?
Sorry for my low skills.

@rnveach
Copy link
Member

rnveach commented Oct 27, 2017

I restarted shippable. It just said it was cancelled.

@dyominov
Copy link
Contributor Author

@romani Can you please check my PR because travis not not run. I see that rnveach test this PR travis and all case was pass, but not view in this checks.
Can you tell me what i do next?

@rnveach
Copy link
Member

rnveach commented Oct 27, 2017

I restarted travis.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine, ok to merge.
@rnveach , please do final review

@rnveach rnveach merged commit 5a78c7d into checkstyle:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants