Issue #6586: aligned javadoc/xdoc for VariableDeclarationUsageDistance #6662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
rnveach
approved these changes
Apr 14, 2019
rnveach
reviewed
Apr 14, 2019
| * <property name="ignoreVariablePattern" value="^temp.*"/> | ||
| * <property name="validateBetweenScopes" value="true"/> | ||
| * <property name="ignoreFinal" value="false"/> | ||
| * <module name="VariableDeclarationUsageDistance"> |
There was a problem hiding this comment.
@pbludov I believe you are doing these type of changes by hand, correct? I see the xdoc still uses " instead of ".
Maybe consider enforcing the program to replace these for you so it won't be a manual process and future contributors will be forced to make this change too.
Doing something like this on xdoc will probably require something like XdocPagesTest.testAllXmlExamples (or a modification to it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6586 (part of #5750)
No changes in the code.