New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #7573: update doc for MissingOverride #7789
Conversation
7f11e1e
to
77aae36
Compare
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Show resolved
Hide resolved
77aae36
to
69b9dc5
Compare
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
Please rebase on latest master to resolve CI spellchecker issue. |
ff4c4c9
to
b5d9644
Compare
In my local computer, all tests pass, but wercker/build failed and I can't see details, so please give me some help. @strkkk |
Please fix failing travis. Wercker has to be ignored now as we are trying to fix an issue with it. |
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
30f779a
to
dceb8c8
Compare
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
dceb8c8
to
a6b3501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HuGanghui please also update first post
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheck.java
Outdated
Show resolved
Hide resolved
a6b3501
to
7f40150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last minor
@HuGanghui I have added review comments above, please take a look |
7f40150
to
9214cbc
Compare
Can be merged after CI pass |
Issue #7573: update doc for MissingOverride
Ouput of default example:
$ cat config.xml
$ cat Test.java
$ RUN_LOCALE="-Duser.language=en -Duser.country=US"
$ java $RUN_LOCALE -jar /var/tmp/checkstyle-8.31-SNAPSHOT-all.jar -c config.xml Test2.java
Starting audit...
[ERROR] /var/tmp/Test.java:10: Must include @java.lang.Override annotation when {@inheritdoc} Javadoc tag exists. [MissingOverride]
[ERROR] /var/tmp/Test.java:15: The Javadoc {@inheritdoc} tag is not valid at this location. [MissingOverride]
[ERROR] /var/tmp/Test.java:20: The Javadoc {@inheritdoc} tag is not valid at this location. [MissingOverride]
Audit done.
Checkstyle ends with 3 errors.
Ouput of configure the check for the javaFiveCompatibility mode:
$ cat config.xml
$ cat Test.java
$ RUN_LOCALE="-Duser.language=en -Duser.country=US"
$ java $RUN_LOCALE -jar /var/tmp/checkstyle-8.31-SNAPSHOT-all.jar -c config.xml Test.java
Starting audit...
[ERROR] /var/tmp/Test.java:4: Must include @java.lang.Override annotation when {@inheritdoc} Javadoc tag exists. [MissingOverride]
[ERROR] /var/tmp/Test.java:12: Must include @java.lang.Override annotation when {@inheritdoc} Javadoc tag exists. [MissingOverride]
Audit done.
Checkstyle ends with 2 errors.