New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #8328: Change name of checkstyle types to be close to real java types - enums #8337
Conversation
03c9c3f
to
70d83e7
Compare
@gaurabdg I restarted wercker, but if it fails again - please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI
There is a failure in spring-integration
|
src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleCheck.java
Outdated
Show resolved
Hide resolved
src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsPagesTest.java
Outdated
Show resolved
Hide resolved
70d83e7
to
4674c0c
Compare
@@ -1029,46 +1029,46 @@ else if (fieldClass == Pattern[].class) { | |||
result = "Regular Expressions"; | |||
} | |||
else if (fieldClass == SeverityLevel.class) { | |||
result = "Severity"; | |||
result = "SeverityLevel"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me all this could be reduced to:
} else if (fieldClass.isEnum()) {
result = fieldClass.getSimpleName();
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
4674c0c
to
f10790a
Compare
@gaurabdg please fix CI issues |
… real java types - enums
f10790a
to
c2ffb7f
Compare
#8328
Refactored -
ClosingParensOption
ElementStyleOption
TrailingArrayCommaOption
All other enums already have
Option
suffix already and just required a bit of renaming inproperty_types.html
related files