Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #8328: Change name of checkstyle types to be close to real java types - misc #8342

Merged
merged 1 commit into from Jul 2, 2020

Conversation

gaurabdg
Copy link
Contributor

@gaurabdg gaurabdg commented Jun 25, 2020

#8328

Types Refactored in first commit -

  1. Pattern
  2. URI
  3. File
  4. Scope
  5. AccessModifierOption[]

@gaurabdg gaurabdg changed the title Issue #8311: Change name of checkstyle types to be close to real java types - misc Issue #8328: Change name of checkstyle types to be close to real java types - misc Jun 25, 2020
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to move Pattern and array of them to separate PR. to let other change be merged quicker.

@gaurabdg gaurabdg force-pushed the refactor-types-misc branch 3 times, most recently from f153622 to dcebce8 Compare June 29, 2020 20:08
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

src/xdocs/config_naming.xml Outdated Show resolved Hide resolved
src/xdocs/config_naming.xml Outdated Show resolved Hide resolved
@romani romani merged commit bef0601 into checkstyle:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants