Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #8328: Change name of checkstyle types to be close to real java types - basic types #8343

Merged
merged 1 commit into from Jul 2, 2020
Merged

Issue #8328: Change name of checkstyle types to be close to real java types - basic types #8343

merged 1 commit into from Jul 2, 2020

Conversation

gaurabdg
Copy link
Contributor

@gaurabdg gaurabdg commented Jun 25, 2020 •
edited

#8328

Refactored

  1. integer -> Integer
  2. boolean -> Boolean
  3. integerSet -> int[]
  4. create Double and double[]
  5. stringSet -> String[]

strkkk
strkkk requested changes Jun 26, 2020
View reviewed changes
src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionFilter.java Outdated Show resolved Hide resolved
src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionFilter.java Outdated Show resolved Hide resolved
src/xdocs/config_filters.xml Outdated Show resolved Hide resolved
src/xdocs/config_filters.xml Outdated Show resolved Hide resolved
@gaurabdg gaurabdg requested a review from strkkk June 26, 2020 09:47
rnveach
rnveach requested changes Jun 26, 2020
View reviewed changes
src/xdocs/property_types.xml Outdated Show resolved Hide resolved
src/xdocs/property_types.xml Outdated Show resolved Hide resolved
src/xdocs/property_types.xml Outdated Show resolved Hide resolved
romani
romani requested changes Jun 27, 2020
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item:

src/xdocs/config_design.xml Outdated Show resolved Hide resolved
@romani
Copy link
Member

romani commented Jun 27, 2020

Looks like update will be tricky ... let remove from this PR update for String[] we will do this separately, with special attention to each property. Please try to do most simple update sooner, and we will left for later some controversial cases.

Please send PR with update of option names to make all of them end with "Option".

Please create one more PR to update https://checkstyle.org/property_types.html and reference all basic types (int, char, ..... , int[], char[], ....), we support them so no matter is Checks have them or not they should be referenced.

@gaurabdg gaurabdg force-pushed the refactor-types-java branch 2 times, most recently from ca88055 to 42bd80d Compare June 29, 2020 19:49
romani
romani requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@romani romani left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please always recheck links that they are working.

failed wercker was restarted, there was artifact downlaod issue.

items:

src/xdocs/releasenotes_old.xml Outdated Show resolved Hide resolved
@gaurabdg gaurabdg requested review from romani and rnveach July 1, 2020 22:52
@romani romani merged commit 854d2e2 into checkstyle:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@strkkk strkkk strkkk approved these changes

@rnveach rnveach Awaiting requested review from rnveach

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaurabdg @romani @rnveach @strkkk