Issue #8764: Create new check IllegalIdentifierName

[nrmancuso]

Issue #8764: Create new check IllegalIdentifierName

Diff Regression projects: https://gist.githubusercontent.com/nmancus1/e3988f8092d919b5cbe70f5359c4d9e8/raw/a0f6f5860f8025c19868061dee6e0e40960b992f/projects-to-test-on.properties

Diff Regression config: https://gist.githubusercontent.com/nmancus1/a6d651fb8e00bf39244b85c05ac809b8/raw/25957bb9583e66aaa6d4849838ecfae77eac2070/Base.xml

Diff Regression patch config: https://gist.githubusercontent.com/nmancus1/eb3dfff886148844a5b58523914109e3/raw/a20fbc07b5fd63f33c776fc20a1d2d725e86d735/IllegalIdentifierName.xml

Contribution PR: checkstyle/contribution#503

Link to site: https://nmancus1.github.io/site_illegalidentifiername/config_naming.html#IllegalIdentifierName

[nrmancuso]

Github, generate report

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/full-records-IllegalIdentifierName_2020124549/reports/diff/index.html

[nrmancuso]

Github, generate report

[romani]

from wercker:

[INFO] --- maven-checkstyle-plugin:3.1.1:check (check) @ patch-diff-report-tool ---
[INFO] There are 4 errors reported by Checkstyle 8.36-SNAPSHOT with ../../../config/checkstyle_checks.xml ruleset.
[ERROR] src/main/java/com/github/checkstyle/parser/CheckstyleTextParser.java:[176,36] (naming) IllegalIdentifierName: Name 'record' must match pattern '(?i)^(?!(record|yield|var)$).+$'.
[ERROR] src/main/java/com/github/checkstyle/parser/CheckstyleTextParser.java:[222,32] (naming) IllegalIdentifierName: Name 'record' must match pattern '(?i)^(?!(record|yield|var)$).+$'.
[ERROR] src/main/java/com/github/checkstyle/data/DiffReport.java:[132,31] (naming) IllegalIdentifierName: Name 'record' must match pattern '(?i)^(?!(record|yield|var)$).+$'.
[ERROR] src/main/java/com/github/checkstyle/site/SiteGenerator.java:[166,35] (naming) IllegalIdentifierName: Name 'record' must match pattern '(?i)^(?!(record|yield|var)$).+$'.

please fix indentation problem in html - https://nmancus1.github.io/site_illegalidentifiername/config_naming.html#IllegalIdentifierName for configs.

[strkkk]

@nmancus1 I suggest to extend list of illegal identifiers-keywords with '_' (underscore) - https://stackoverflow.com/questions/23523946/underscore-is-a-reserved-keyword

FYI for new module report you should not use patch report generation, but new module link prefixes instead, it is clearer. https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#basic-single-report

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/full-records-IllegalIdentifierName_2020145342/reports/diff/index.html

[nrmancuso]

@strkkk

I suggest to extend list of illegal identifiers-keywords with '_' (underscore) - https://stackoverflow.com/questions/23523946/underscore-is-a-reserved-keyword

This is a good suggestion, thanks.

FYI for new module report you should not use patch report generation, but new module link prefixes instead, it is clearer. https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#basic-single-report

Thank you, that is a good point. Should I amend and re-run report generation?

[strkkk]

Thank you, that is a good point. Should I amend and re-run report generation?

I don't think it is necessary in this case, it is for future usages.

[nrmancuso]

I suggest to extend list of illegal identifiers-keywords with '_' (underscore)

I misunderstood this at first, I am updating this PR now.

Edit: _ is now an illegal identifier name.

[nrmancuso]

Site is updated.

[romani]

Github, generate report

[romani]

Minor:

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/full-records-IllegalIdentifierName_2020215000/reports/diff/index.html

[romani]

codecov could be ignored.
We lost coverage % a bit, by metadata PR merge, that is why it might be messing with math of %.

While jacoco and pitest are happy, codecov can be ignored.

[pbludov]

two minor changes please