Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #200: Edit default config for checkstyle tester to produce no violations #201

Merged
merged 1 commit into from
Mar 27, 2017
Merged

Issue #200: Edit default config for checkstyle tester to produce no violations #201

merged 1 commit into from
Mar 27, 2017

Conversation

MEZk
Copy link
Contributor

@MEZk MEZk commented Mar 23, 2017 •
edited
Loading

#200

It default config is not changed we will get the following diff report:

image

Sorry, but my IDEA continues reformatting blank lines with tabs even if I disable code formatting before a commit.

@MEZk MEZk force-pushed the i200-default-config branch 2 times, most recently from 64d51a8 to 7ac88bc Compare March 23, 2017 20:36
@romani
Copy link
Member

romani commented Mar 24, 2017

Appveyor is restarted.

Please use plain text editor to remove tabs from file.

@romani
Copy link
Member

romani commented Mar 24, 2017

build was restarted on master and now it is failing

@romani
Copy link
Member

romani commented Mar 24, 2017

smth wrong with parsing of property file.
@rnveach , can you run this on your Windows to get us understanding what is going on ...

@rnveach
Copy link
Member

rnveach commented Mar 24, 2017 •
edited
Loading

@romani I believe the issue is the blank line isn't being skipped and is treated as a repository.

When I add echo $line|hexdump -v to print the line in launch.sh, I get the following results:

0000000 0a0d
0000002

@rnveach
Copy link
Member

rnveach commented Mar 24, 2017

There is also a version difference in cygwin in build history:
bad: Starting cygwin install, version 2.877
good: Starting cygwin install, version 2.874

@romani romani mentioned this pull request Mar 24, 2017
Closed
@romani
Copy link
Member

romani commented Mar 24, 2017

appveyor config was updated - c77e408

@MEZk , please rebase on latest code to pass CIs

@MEZk
Copy link
Contributor Author

MEZk commented Mar 25, 2017 •
edited
Loading

@romani
Done.

Please use plain text editor to remove tabs from file.

Git on my laptop is configured to automatically replace tabs with spaces and also to remove blank lines which contain only tabs. Are we OK with tabs replacement in my_check.xml?

I also added a short notice into README.md.

romani
romani requested changes Mar 25, 2017
View reviewed changes
checkstyle-tester/my_check.xml Outdated
<!-- Example of checkstyle Check usage -->
<module name="AbstractClassName"/>
<module name="ThrowsCount">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space is missed for indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

rnveach
rnveach requested changes Mar 25, 2017
View reviewed changes
checkstyle-tester/README.md Outdated
@@ -130,7 +130,7 @@ The script receives the following set of command line arguments:

**patchConfig** (pc) - path to the patch checkstyle config file. It will be applied to patch branch (required if baseConfig is specified);

**config** (c) - path to the checkstyle config file. It will be applied to base and patch branches (required if baseConfig and patchConfig are not secified);
**config** (c) - path to the checkstyle config file. It will be applied to base and patch branches (required if baseConfig and patchConfig are not secified). The defalt config should be changed in order to be appropriate for your use purposes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defalt -> default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

@rnveach rnveach merged commit b3b1708 into checkstyle:master Mar 27, 2017
@MEZk MEZk deleted the i200-default-config branch March 29, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@rnveach rnveach rnveach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MEZk @romani @rnveach