Issue #251: ci:build patch-filter jar buring a build

[HuGanghui]

Issue #251: ci:build patch-filter jar buring a build

this refers to #246

[romani]

please rebase and resolve CI failure

[romani]

Good step forward, but we need to have config of checkstyle (copy from main repo + new filters) and usage of it maven pom.xml.

You can test all on your local by the same command as we use in CI

[HuGanghui]

but we need to have config of checkstyle (copy from main repo + new filters) and usage of it maven pom.xml.

@romani I am not clear about it, does it mean that I need to add a checkstyle config in to eclipse-cs and then test eclipse-cs in Eclipse?

[romani]

No, you need to add
Checkstyle execution same as at https://github.com/checkstyle/sonar-checkstyle/blob/c9a22205393b4d777548e9b414c5cb64628e35b2/pom.xml#L405
With only difference is that checkstyle config will be hosted in repo config folder and contains two more filters.

Execution of mvn verify should trigger execution of checkstyle a validate code

[romani]

Items:

[romani]

Please use https://github.com/checkstyle/eclipse-cs/blob/master/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/CheckstylePlugin.java#L1 for header file in checkstyle config

[romani]

please do same as CI do:
CMD="./build-metafile-gen.sh && ./build-patch-filter.sh && mvn install

[romani]

items:

[HuGanghui]

@romani

...please execute your config in eclipse-cs on multiple commits to make sure it works and could produce some violations
Your report generator might come handy

if what you mean is that using report generator in ci, then it is not easy to use, because it need Checkstyle repository and Contribution repository, if just use report-generator in eclipse-cs, here is the result: checkstyle/patch-filters#297

[romani]

if what you mean is that using report generator in ci

Not in CI. Do on local and share report.

[romani]

items:

[romani]

remove && git diff HEAD~2 HEAD~1 > target/show.patch && mvn clean verify

install already to verify

[HuGanghui]

done

[romani]

item:

[romani]

item:

[romani]

@Calixte , FYI.

We will remove HACK with build.....sh script ones I deploy patch filter to maven repo.

Id there will be any false positives from Checkstyle validation of code, we might disable it, but for now this will help us to start following checkstyle config from now, all new code should follow checkstyle style.