Upgrade to 10.10.0 #587
Merged
Upgrade to 10.10.0 #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new filter works, but every adding/removing of a filter comment only hides/re-adds a violation after purging the Checkstyle cache, not on save.
|
Please link issue to cache, to make it clear we see issue and it is registered and will be handled separately. |
|
Only afterwards I noticed that @Calixte had already described that same problem in the initial issue: #524 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new filter works, but every adding/removing of a filter comment only hides/re-adds a violation after purging the Checkstyle cache, not on save like for any other file content change. I'm not sure if that is a problem in the main checkstyle part or in Eclipse-CS. I'd still suggest to commit and release the upgrade and to investigate why cache purging is needed only later.
Fixes #524.