Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Checkers filter SuppressionPatchFilter that suppress all violations on non affected lines #4

Closed
romani opened this issue Jun 6, 2020 · 1 comment
Closed

Create Checkers filter SuppressionPatchFilter that suppress all violations on non affected lines #4

romani opened this issue Jun 6, 2020 · 1 comment
Projects
Patch Suppression

Comments

@romani
Copy link
Member

romani commented Jun 6, 2020 •
edited

implementation could be imperfect by all means, if few test cases are passing it is ok to merge and shift to test script creation.

All known items to improve in Filter should be moved to separate issue.
@romani romani mentioned this issue Jun 6, 2020
Closed
@romani romani changed the title Create Checkers filter that suppress all violations on non affected lines Create Checkers filter SuppressionPatchFilter that suppress all violations on non affected lines Jun 6, 2020
@romani romani added this to To do in Patch Suppression Jun 7, 2020
HuGanghui added a commit to HuGanghui/patch-filters that referenced this issue Jun 8, 2020
@HuGanghui
Issue checkstyle#4: Create Checkers filter SuppressionPatchFilter tha…
01097f1 
…t suppress all violations on non affected lines
@HuGanghui HuGanghui mentioned this issue Jun 8, 2020
Merged
HuGanghui added a commit to HuGanghui/patch-filters that referenced this issue Jun 10, 2020
@HuGanghui
Issue checkstyle#4: Create Checkers filter SuppressionPatchFilter tha…
48b4599 
…t suppress all violations on non affected lines
HuGanghui added a commit to HuGanghui/patch-filters that referenced this issue Jun 10, 2020
@HuGanghui
Issue checkstyle#4: Create Checkers filter SuppressionPatchFilter tha…
12d2b9f 
…t suppress all violations on non affected lines
romani pushed a commit that referenced this issue Jun 10, 2020
@HuGanghui @romani
Issue #4: Create Checkers filter SuppressionPatchFilter that suppress…
494b700 
… all violations on non affected lines
@romani
Copy link
Member Author

romani commented Jun 10, 2020

very very basic implemetation is merged

@romani romani closed this as completed Jun 10, 2020
Patch Suppression automation moved this from To do to Done Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Patch Suppression
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romani