Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11: provide UT for path on multiple files #13

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Issue #11: provide UT for path on multiple files #13

merged 1 commit into from
Jun 14, 2020

Conversation

HuGanghui
Copy link
Contributor

Issue #11: provide UT for path on multiple files

@HuGanghui HuGanghui marked this pull request as draft June 11, 2020 03:56
@HuGanghui HuGanghui marked this pull request as ready for review June 11, 2020 10:18
@romani
Copy link
Member

romani commented Jun 12, 2020

@HuGanghui , please rebase , I merged your commit with organized inputs

@HuGanghui
Copy link
Contributor Author

@romani finish rebase

@romani romani mentioned this pull request Jun 13, 2020
Closed
@romani
Copy link
Member

romani commented Jun 13, 2020

@HuGanghui , @rdiachenko , reminder ....
we do not need well implemented functionality, all we need in POC is code that works with git diff, that we will use during testing.
All other we can do later on, if something is noticed and good to do but not requied for POC, please move to separate issue.

@romani romani linked an issue Jun 13, 2020 that may be closed by this pull request
provide UT for Filter with patch on multiple files #11
Closed
@rdiachenko rdiachenko merged commit 7898201 into checkstyle:master Jun 14, 2020
@HuGanghui HuGanghui deleted the multiChangeOnOneFile branch June 14, 2020 09:34
@HuGanghui HuGanghui mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani left review comments

@rdiachenko rdiachenko rdiachenko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide UT for Filter with patch on multiple files
3 participants
@HuGanghui @romani @rdiachenko