Issue #74: Create unit tests for line strategy for Checker checks (non-TreeWalker) #84
Conversation
HuGanghui
force-pushed
the
UT-for-test
branch
2 times, most recently
from
6e4d366
to
3906ebf
Compare
| @@ -0,0 +1,31 @@ | |||
| diff --git a/src/main/java/Checker/FileLength/Test.java b/src/main/java/Checker/FileLength/Test.java | |||
There was a problem hiding this comment.
please fix path to files, it might not be critical in this particular case, but will be good practice ones we come to multifile and different folders diffs.
| diff --git a/src/main/java/Checker/FileLength/Test.java b/src/main/java/Checker/FileLength/Test.java | ||
| index f8603ef..d10d86a 100644 | ||
| --- a/Test/Test.java | ||
| +++ b/Test/Test.java |
…checks (non-TreeWalker)
|
Merged in scope of #86 |
| public class Test { | ||
| // Long line ---------------------------------------------------------------- | ||
| // Contains a tab -> <- //warn | ||
| // Contains trailing whitespace -> |
There was a problem hiding this comment.
Looks like you don't need trailing spaces in this input file. FileTabCharacter doesn't check them
| @@ -0,0 +1,14 @@ | |||
| package Checker.FileLength; | |||
There was a problem hiding this comment.
Please add comments to all input files where you expect a violation. It's hard to always compare with expected.txt and patch.diff.
Something like: // violation newline/patchedline or // violation newline (depends on violation and strategy)
| @@ -0,0 +1,4 @@ | |||
| Starting audit... | |||
| [ERROR] /Users/hgh/Downloads/my_file/IDEA_workspace/patchfiltergeneratepatch/src/main/java/Checker/RegexpMultiline/Test.java:18: Line matches the illegal pattern 'System\.out\.\n print\('. [RegexpMultiline] | |||
There was a problem hiding this comment.
this line is not expected as I understand, because patch changes line 19, and this violation is for number 18. This should be covered by context strategy. Am I correct?
There was a problem hiding this comment.
@baratali yes, you are correct, and I have add notes in UT about RegexpMultiline that this situation will be solved in context strategy.
There was a problem hiding this comment.
@HuGanghui , please remove this line if it's not expected in patchedline strategy.
Issue #74: Create unit tests for line strategy for Checker checks (non-TreeWalker)