Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #328: fix for validationType for non base token properties #330

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Issue #328: fix for validationType for non base token properties #330

merged 1 commit into from
Sep 12, 2020

Conversation

gaurabdg
Copy link
Contributor

@gaurabdg gaurabdg commented Sep 5, 2020 •
edited

Issue #328

DescendantTokenCheck

Screenshot 2020-09-05 at 9 29 24 PM

execution:

Screenshot 2020-09-12 at 4 09 09 PM

MultipleStringLiteralsCheck

Screenshot 2020-09-05 at 9 32 02 PM

execution:

Screenshot 2020-09-06 at 4 21 20 AM

MagicNumberCheck

Screenshot 2020-09-05 at 10 03 16 PM

execution:

Screenshot 2020-09-06 at 4 48 53 AM

IllegalTypeCheck

Screenshot 2020-09-05 at 10 09 22 PM

execution:

Screenshot 2020-09-06 at 5 37 06 PM

AtclauseOrderCheck

Screenshot 2020-09-05 at 3 53 41 AM

execution:

Screenshot 2020-09-06 at 6 44 30 PM

@romani
Copy link
Member

romani commented Sep 6, 2020 •
edited

https://checkstyle.org/config_misc.html#DescendantToken

tokens is not referenced in javadoc and xdoc.
We usually have such model ONLY for cases when tokens is not configurable (getRequredToekns == getAcceptableTokens).
but this is different case, we just need all tokens. We might did not wanted to list all tokens, as it is too much we were too lazy.
Lets do some HACK to unblock us:
please introduce tokens to javadoc and make new type all tokens TokenTypes
and please make all required hacks in UTs to make them appear in metafiles as list of all tokens or just as type allTokenTypes to let plugins treat them in special way.

https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtil.java#L140

@gaurabdg gaurabdg mentioned this pull request Sep 7, 2020
Closed
@gaurabdg gaurabdg force-pushed the urgent-fix-validationtype branch 2 times, most recently from 3f1f1d4 to d327d1e Compare September 12, 2020 10:42
@muhlba91
Copy link
Contributor

please check build failures :)

romani
romani requested changes Sep 12, 2020
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

pom.xml Outdated Show resolved Hide resolved
@gaurabdg gaurabdg force-pushed the urgent-fix-validationtype branch 2 times, most recently from 196310b to 1847ed0 Compare September 12, 2020 16:21
@romani
Copy link
Member

romani commented Sep 12, 2020

Wercker is failed in sonar validation
Cloning into 'blog-sonar-build-breaker'... Timeout of + 36 + seconds exceeded

The same problem is in checkstyle repo, I am not sure why ...

@romani romani merged commit d995970 into checkstyle:master Sep 12, 2020
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani requested changes

@muhlba91 muhlba91 muhlba91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaurabdg @romani @muhlba91